Xqt added a comment.
As noted in rPWBCa0a45d60c79726a934d2382823f54ee986837494 <https://phabricator.wikimedia.org/rPWBCa0a45d60c79726a934d2382823f54ee986837494> there are multiple matches for test wiki which should be solved: > I found two issues with this patch: > >> Site('test', 'wikipedia') == Site('test', 'test') # should be True > > False > >> Site().fromDBName('testwiki') # should not warn > > WARNING: Found multiple matches for URL \ "https://test.wikipedia.org/w/index.php": \ ('test', Family("test")), ('test', Family("wikipedia")) (use first) APISite("test", "test") > Note that the first issue is not introduced by this patch (it already exists on master). > The cause of the mentioned issues is that we have two separate family > files that contain the same site. IOW, test.wikipeida.org is defined > both in test_family.py and in wikipedia_family.py. It should be removed > from one of them, but that sounds like a big breaking change and requires > a deprecation period. This patch is not going to get into that matter. > Bug: T225590 <https://phabricator.wikimedia.org/T225590> TASK DETAIL https://phabricator.wikimedia.org/T228300 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, pywikibot-bugs-list, Dalba, Xqt, Viztor, DannyS712, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
