matej_suchanek created this task.
matej_suchanek triaged this task as "High" priority.
matej_suchanek added projects: Pywikibot, Pywikibot-replace.py, Regression.
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION
  Even though I specified `-summary` or entered a summary for `Press Enter to 
use this automatic message, or enter a description of the changes your bot will 
make:`, the edit was saved with the default: 
https://cs.wikipedia.org/w/index.php?title=Ahorn_(Horn%C3%AD_Rakousy)&diff=prev&oldid=18467566&diffmode=source.
  
  This is a regression from 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/154824.
  
  Also note that the variable `edit_summary` is written to but never used:
  
    if ((not edit_summary or edit_summary is True)
            and (missing_fixes_summaries or single_summary)):
        if single_summary:
            pywikibot.output('The summary message for the command line '
                             'replacements will be something like: '
                             + single_summary)
        if missing_fixes_summaries:
            pywikibot.output('The summary will not be used when the fix has '
                             'one defined but the following fix(es) do(es) '
                             'not have a summary defined: '
                             '{0}'.format(', '.join(missing_fixes_summaries)))
        if edit_summary is not True:
            edit_summary = pywikibot.input(
                'Press Enter to use this automatic message, or enter a '
                'description of the\nchanges your bot will make:')
        else:
            edit_summary = ''

TASK DETAIL
  https://phabricator.wikimedia.org/T251669

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matej_suchanek
Cc: Xqt, Aklapper, matej_suchanek, pywikibot-bugs-list, Dijkstra, Djradon, 
Zkhalido, Viztor, Wenyi, Jayprakash12345, Tbscho, MayS, Mdupont, JJMC89, 
Dvorapa, Altostratus, binbot, Avicennasis, Wong128hk, mys_721tx, jayvdb, Masti, 
Alchimista, Rxy
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to