Xqt added a comment.
In T196039#4245909 <https://phabricator.wikimedia.org/T196039#4245909>, @Urbanecm wrote: > @Xqt Try to use replace.py and confirm/reject/modify all diffs without having to wait on the "save" thread. It is impossible, so the replace.py logic is not (at least not fully) async. Cannot really reproduce it. But I re-implemented cached output from compat in https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/282818/ and discarded all these callback changes in replace.py (which does not work properly especially for other messages than saving hints) to use the default BaseBot's behaviour. In addition I introduce a saving delay for `-simulate` option with https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/607072/ and awaiting put threads beeing done during BaseBot.exit() in https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/607170/. With these concepts I do not find a sticking async behaviour. A good simulating command could be: `py -3 pwb.py replace -simulate a b -start:! -summary:"Bot: Tests"` Confirm several changes with [`y`]es and stop with [`q`]uit then. TASK DETAIL https://phabricator.wikimedia.org/T196039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, matej_suchanek, Xqt, Urbanecm, pywikibot-bugs-list, Dvorapa, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Altostratus, binbot, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
