Mpaa created this task. Mpaa added a project: Pywikibot. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTION Sometimes, requests.Exceptions are checked directly and then converted outside http.py (e.g. here <https://github.com/wikimedia/pywikibot/blob/5faf56076d67f98ecbd26f924e96b27670e42bcf/pywikibot/pagegenerators.py#L2913>, or here <https://github.com/wikimedia/pywikibot/blob/809ab27dd50810f89c807b372cbc3f8dc626366a/pywikibot/proofreadpage.py#L610>), while some exceptions are converted in http.error_handling_callback(). A review should be carried out and a general guideline defined: - is it OK to handle requests.Exceptions directly? - shall they be filtered and converted centrally in htt.fetch()? - ... TASK DETAIL https://phabricator.wikimedia.org/T270051 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mpaa Cc: Aklapper, pywikibot-bugs-list, Mpaa, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
