Xqt added a comment.

  As noted above the blockpageschecker is archived due to T223826 
<https://phabricator.wikimedia.org/T223826> until someone asks for restoring 
it. Therefore it is not intendet to update that script currently.
  
  Anyway there are a lot of parts to be improved with your patch:
  
  - please follow 
[https://www.mediawiki.org/wiki/Manual:Coding_conventions/Python | Python 
Coding Conventions]
  - please follow 
[https://www.mediawiki.org/wiki/Manual:Pywikibot/Development/Guidelines | 
Pywikibot Development Guidlines]
  - Functions should not be in mixed case
  - print Statements should never be used; use pywikibot.output() or one of the 
other pywikibot.logging functions
  - never use bare exceptions
  - use a defaultdict in your fetchCategoriesToCheck
  - return None if fetchCategoriesToCheck fails
  - categoryToCheck[config.mylang][0] may fail if mylang is not found in the 
dict
  - -url Option is not documented
  - don't use f-strings because it does not  work for older Pythons < 3.7
  - why to use pywikibot.output(f'*******************{page} '), pagename is 
already printed in next line

TASK DETAIL
  https://phabricator.wikimedia.org/T232245

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Pradyumn_lex, Shubham-sp35, Mh-3110, Xqt, Aklapper, pywikibot-bugs-list, 
patilise, Abhinay76, Annysah01, Rohitgeddam, Jyoo1011, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Soda, Chaytanya, Zkhalido, wiki-helenatxu, Viztor, Wenyi, 
Kieubinhtb, Tks4Fish, Asad_Ali_Palijo, Lahi, Soteriaspace, JakeTheDeveloper, 
Tbscho, MayS, Mdupont, JJMC89, Dvorapa, xSavitar, Altostratus, Avicennasis, 
MuhammadShuaib, Tmalhotra, SimmeD, mys_721tx, jayvdb, Masti, Alchimista, Rxy
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to