Xqt added a comment.
In T278040#6944570 <https://phabricator.wikimedia.org/T278040#6944570>, @Rubin16 wrote: > @Xqt > seems to be working, thanks a lot. Let's merge and I will do a more continuous run to test it more. > > PS: Just for my self-education (you can ignore it, if you want): > > - I see that you have changed the logic from adding +1 to the existing ref names getting a free one in the range 1-999, right? why do you believe it is better? > - what was the bug? just curious The old implementation assumes that there auto generated identifiers starting with 1 e. g autogen1 autogen2, autogen3. reflinks starts counting with 4 then. In your example this fails because autogen7 was already there but it was created anyway. The new implementation looks for any auto generated number and excludes them from reusing. TASK DETAIL https://phabricator.wikimedia.org/T278040 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Xqt, Aklapper, pywikibot-bugs-list, Rubin16, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
