Xqt created this task.
Xqt added projects: Pywikibot, Pywikibot-tests.
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION
  **List of steps to reproduce**:
  https://github.com/xqt/pwb/runs/4737554636?check_suite_focus=true for example
  
  **What happens?**:
  
    ======================================================================
    FAIL: test_dry (tests.deletionbot_tests.TestDeletionBot)
    Test dry run of bot.
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/home/runner/work/pwb/pwb/tests/deletionbot_tests.py", line 105, in 
test_dry
        delete.main('-page:Main Page', '-always', '-summary:foo')
      File "/home/runner/work/pwb/pwb/scripts/delete.py", line 291, in main
        bot.run()
      File "/home/runner/work/pwb/pwb/pywikibot/bot.py", line 1596, in run
        self.treat(page)
      File "/home/runner/work/pwb/pwb/pywikibot/bot.py", line 1851, in treat
        self.treat_page()
      File "/home/runner/work/pwb/pwb/scripts/delete.py", line 212, in 
treat_page
        self.current_page.site.login()
      File "/home/runner/work/pwb/pwb/pywikibot/site/_apisite.py", line 390, in 
login
        assert self.userinfo['name'] == self.username(), \
    AssertionError: 20.106.97.78 != ***
  
  **What should have happened instead?**:
  
  1. We could decrease parallel actions to 1. In result none or only a few 
action tasks will fail, see https://github.com/xqt/pwb/actions/runs/1663138832 
for example but the test time increases from 1 hour to 4 hours then.
  2. We could remove the assert check in APISite.login() and use not logged in 
status. Most tests will just skip then.
  3. The reason might be login/logout checks done in parallel task. We should 
make a separate action for this
  
  **Software version**:
  Pywikibot 7.0.0

TASK DETAIL
  https://phabricator.wikimedia.org/T298761

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Aklapper, pywikibot-bugs-list, Xqt, Jyoo1011, JohnsonLee01, SHEKH, 
Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, JJMC89, 
Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
_______________________________________________
pywikibot-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to