JJMC89 closed this task as "Resolved". JJMC89 added a comment.
In T299309#7624739 <https://phabricator.wikimedia.org/T299309#7624739>, @Xqt wrote: > @matej_suchanek: @JJMC89: The layer parameter is mandatory for `debug()` function.[1] > > Usually a global `_logger` variable is used and passed to `debug()` [2][3] but I don't see any benefit to have different logger for debug() (which does not mean to have different files) whereas other logging functions like `log()` or `output()` could have different logger but all of them uses our default `'pywiki'` logger. The log file does not use the logger name. I propose to remove the global `_logger` variables and make the layer parameter optional for `debug()`. Sorry about this. I always forget that the layer is required for `debug()`. I thought the purpose was that so only part of the debug logging can be enabled. In any case, making all of the logging interfaces the same is a good idea. If we don't want to remove the layer for some reason, at least defaulting it would be good. TASK DETAIL https://phabricator.wikimedia.org/T299309 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, JJMC89 Cc: Dvorapa, Aklapper, pywikibot-bugs-list, Xqt, JJMC89, matej_suchanek, 786, Suran38, Biggs657, Lalamarie69, Jyoo1011, JohnsonLee01, Juan90264, SHEKH, Dijkstra, Alter-paule, Beast1978, Un1tY, Khutuck, Zkhalido, Hook696, Kent7301, joker88john, Viztor, CucyNoiD, Wenyi, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Jayprakash12345, Tbscho, MayS, Lewizho99, Mdupont, Maathavan, Altostratus, Avicennasis, Wong128hk, mys_721tx, jayvdb, Masti, Alchimista
_______________________________________________ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org
