Mpaa added a comment.

  The return type is specified clearly.
  Scripts that use this function know what to expect and should act accordingly.
  
  latest_file_info(self) and oldest_file_info(self) are available for that 
purpose.
  
  I find problematic that someone pop() an item, as the cached 
self._file_revisions dict will be corrupted.
  It should be clarified in the docstring or a copy should be returned.

TASK DETAIL
  https://phabricator.wikimedia.org/T301800

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa
Cc: Mpaa, Meno25, Aklapper, pywikibot-bugs-list, Xqt, Jyoo1011, JohnsonLee01, 
SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Mdupont, 
JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
_______________________________________________
pywikibot-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to