RoySmith added a comment.
This reminds me of T326996 <https://phabricator.wikimedia.org/T326996>. I took a quick look at the patch. As a general comment, I'd rather see all IP address comparisons done by creating IPv4Address or IPv6Address objects from the stdlib <https://docs.python.org/3/library/ipaddress.html> and comparing those. That would be simpler and more future-proof than scattering textual manipulations like t.upper() around the pywiki code. TASK DETAIL https://phabricator.wikimedia.org/T306291 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, RoySmith Cc: RoySmith, Aklapper, pywikibot-bugs-list, Shubinator, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Framawiki, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, mys_721tx, Xqt, jayvdb, Masti, Alchimista
_______________________________________________ pywikibot-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
