RoySmith added a comment.
I think you've got that backwards, the flag is not set, so it defaults to '0', which is != '1', so the assertion is run. Which leads to a couple of additional observations: If the intent is that this is only run when PYWIKIBOT_TEST_RUNNING == 1, the comparison is backwards. But, deeper than that, why are there tests that are only supposed to run in CI and not otherwise? And looking at the description in pywikibot-git/tests/README.rst, the usage here is contrary to the documented use. TASK DETAIL https://phabricator.wikimedia.org/T336591 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JJMC89, RoySmith Cc: Xqt, Aklapper, pywikibot-bugs-list, RoySmith, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, Framawiki, Mdupont, JJMC89, Dvorapa, Altostratus, binbot, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista
_______________________________________________ pywikibot-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
