hashar added a comment.
With tox 4, `skipsdist = True` cause it to always skip the package installation (`package=skip`) regardless of the value of `usedevelop` which is not even recognized when skipsdist is set. We should thus remove it. With both tox v3 and v4, `usedevelop` causes the `sdist` to be skipped. Side track: when we don't even need the package to be installed (eg to run flake8) we can use `skip_install = True` instead of `usedevelop = True`. Ideally we should have at least one environment running `sdist` to ensure it is working. I have done that in Quibble with tox v3: [testenv:check] skipsdist = False usedevelop = False For tox v4 and removing `skipsdist` entirely, I guess `usedevelop=False` is sufficient and once migrated to tox v4 we can use: `package = sdist`. `usedevelop` can later be changed to `package = editable`. TASK DETAIL https://phabricator.wikimedia.org/T346238 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hashar Cc: pywikibot-bugs-list, Aklapper, hashar, TheReadOnly, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH, Peteosx1x, Dijkstra, Khutuck, Mgagat, Totolinototo3, Zkhalido, Zanziii, Sadisticturd, Viztor, NebulousIris, Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis, Liudvikas, thcipriani, mys_721tx, Xqt, jayvdb, Masti, Alchimista, Krenair
_______________________________________________ pywikibot-bugs mailing list -- pywikibot-bugs@lists.wikimedia.org To unsubscribe send an email to pywikibot-bugs-le...@lists.wikimedia.org