Mpaa added a comment.

  I think that here we could use apipath, as the goal should to check only that 
the site is online.
  
    if 'hostname' not in data and 'site' in data:
        # Ignore if the family has defined this as
        # obsolete without a mapping to a hostname.
        with suppress(KeyError):
            data['hostname'] = (
                data['site'].base_url(data['site'].path()))  -->  
ata['site'].apipath()
  
  But I am not familiar with all implication s of aspects.py

TASK DETAIL
  https://phabricator.wikimedia.org/T352606

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa
Cc: Aklapper, pywikibot-bugs-list, Mpaa, mevo, PotsdamLamb, Jyoo1011, 
JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Viztor, Wenyi, Tbscho, MayS, 
Mdupont, JJMC89, Dvorapa, Altostratus, binbot, Avicennasis, mys_721tx, Xqt, 
jayvdb, Masti, Alchimista
_______________________________________________
pywikibot-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to