Multichill created this task.
Multichill added a project: Pywikibot.
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.
TASK DESCRIPTION
My upload bot ignores faulty certificates because museums often mess these
up. So I get some warning. After the warning the logging module seems to
explode:
WARNING:
/data/project/multichill/pyvenv/lib/python3.11/site-packages/urllib3/connectionpool.py:1103:
InsecureRequestWarning: Unverified HTTPS request is bein
g made to host 'd3d00swyhr67nd.cloudfront.net'. Adding certificate
verification is strongly advised. See:
https://urllib3.readthedocs.io/en/latest/advanced-us
age.html#tls-warnings
warnings.warn(
--- Logging error ---
Traceback (most recent call last):
File "/usr/lib/python3.11/logging/handlers.py", line 73, in emit
if self.shouldRollover(record):
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/logging/handlers.py", line 196, in
shouldRollover
msg = "%s\n" % self.format(record)
^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/logging/__init__.py", line 953, in format
return fmt.format(record)
^^^^^^^^^^^^^^^^^^
File "/data/project/multichill/pywikibot/pywikibot/tools/_logging.py",
line 24, in format
assert len(record.args) == 1, \
^^^^^^^^^^^^^^^^^^^^^
AssertionError: Arguments for record is not correctly set
Call stack:
File "/data/project/multichill/./pywikibot/pwb.py", line 40, in <module>
sys.exit(main())
File "/data/project/multichill/./pywikibot/pwb.py", line 36, in main
runpy.run_path(str(path), run_name='__main__')
File "<frozen runpy>", line 291, in run_path
File "<frozen runpy>", line 98, in _run_module_code
File "<frozen runpy>", line 88, in _run_code
File "/data/project/multichill/pywikibot/pywikibot/scripts/wrapper.py",
line 544, in <module>
main()
File "/data/project/multichill/pywikibot/pywikibot/scripts/wrapper.py",
line 528, in main
if not execute():
File "/data/project/multichill/pywikibot/pywikibot/scripts/wrapper.py",
line 515, in execute
run_python_file(filename, script_args, module)
File "/data/project/multichill/pywikibot/pywikibot/scripts/wrapper.py",
line 153, in run_python_file
exec(compile(source, filename, 'exec', dont_inherit=True),
File "./code/bot/commons/wikidata_uploader.py", line 653, in <module>
main()
File "./code/bot/commons/wikidata_uploader.py", line 650, in main
wikidataUploaderBot.run()
File "./code/bot/commons/wikidata_uploader.py", line 238, in run
self.uploadPainting(metadata)
File "./code/bot/commons/wikidata_uploader.py", line 283, in uploadPainting
response = requests.get(metadata.get('downloadurl'), verify=False) #
Museums and valid SSL.....
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/requests/api.py",
line 73, in get
return request("get", url, params=params, **kwargs)
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/requests/api.py",
line 59, in request
return session.request(method=method, url=url, **kwargs)
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/requests/sessions.py",
line 589, in request
resp = self.send(prep, **send_kwargs)
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/requests/sessions.py",
line 703, in send
r = adapter.send(request, **kwargs)
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/requests/adapters.py",
line 486, in send
resp = conn.urlopen(
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/urllib3/connectionpool.py",
line 793, in urlopen
response = self._make_request(
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/urllib3/connectionpool.py",
line 467, in _make_request
self._validate_conn(conn)
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/urllib3/connectionpool.py",
line 1103, in _validate_conn
warnings.warn(
File "/usr/lib/python3.11/warnings.py", line 109, in _showwarnmsg
sw(msg.message, msg.category, msg.filename, msg.lineno,
Message:
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/urllib3/connectionpool.py:1103:
InsecureRequestWarning: Unverified HTTPS request is being made to host
'd3d00swyhr67nd.cloudfront.net'. Adding certificate verification is strongly
advised. See:
https://urllib3.readthedocs.io/en/latest/advanced-usage.html#tls-warnings\n
warnings.warn(\n"
Arguments: ()
--- Logging error ---
Traceback (most recent call last):
File "/usr/lib/python3.11/logging/handlers.py", line 73, in emit
if self.shouldRollover(record):
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/logging/handlers.py", line 196, in
shouldRollover
msg = "%s\n" % self.format(record)
^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/logging/__init__.py", line 953, in format
return fmt.format(record)
^^^^^^^^^^^^^^^^^^
File "/data/project/multichill/pywikibot/pywikibot/tools/_logging.py",
line 24, in format
assert len(record.args) == 1, \
^^^^^^^^^^^^^^^^^^^^^
AssertionError: Arguments for record is not correctly set
Call stack:
File "/data/project/multichill/./pywikibot/pwb.py", line 40, in <module>
sys.exit(main())
File "/data/project/multichill/./pywikibot/pwb.py", line 36, in main
runpy.run_path(str(path), run_name='__main__')
File "<frozen runpy>", line 291, in run_path
File "<frozen runpy>", line 98, in _run_module_code
File "<frozen runpy>", line 88, in _run_code
File "/data/project/multichill/pywikibot/pywikibot/scripts/wrapper.py",
line 544, in <module>
main()
File "/data/project/multichill/pywikibot/pywikibot/scripts/wrapper.py",
line 528, in main
if not execute():
File "/data/project/multichill/pywikibot/pywikibot/scripts/wrapper.py",
line 515, in execute
run_python_file(filename, script_args, module)
File "/data/project/multichill/pywikibot/pywikibot/scripts/wrapper.py",
line 153, in run_python_file
exec(compile(source, filename, 'exec', dont_inherit=True),
File "./code/bot/commons/wikidata_uploader.py", line 653, in <module>
main()
File "./code/bot/commons/wikidata_uploader.py", line 650, in main
wikidataUploaderBot.run()
File "./code/bot/commons/wikidata_uploader.py", line 238, in run
self.uploadPainting(metadata)
File "./code/bot/commons/wikidata_uploader.py", line 283, in
uploadPainting
response = requests.get(metadata.get('downloadurl'), verify=False) #
Museums and valid SSL.....
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/requests/api.py",
line 73, in get
return request("get", url, params=params, **kwargs)
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/requests/api.py",
line 59, in request
return session.request(method=method, url=url, **kwargs)
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/requests/sessions.py",
line 589, in request
resp = self.send(prep, **send_kwargs)
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/requests/sessions.py",
line 703, in send
r = adapter.send(request, **kwargs)
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/requests/adapters.py",
line 486, in send
resp = conn.urlopen(
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/urllib3/connectionpool.py",
line 793, in urlopen
response = self._make_request(
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/urllib3/connectionpool.py",
line 467, in _make_request
self._validate_conn(conn)
File
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/urllib3/connectionpool.py",
line 1103, in _validate_conn
warnings.warn(
File "/usr/lib/python3.11/warnings.py", line 109, in _showwarnmsg
sw(msg.message, msg.category, msg.filename, msg.lineno,
Message:
"/data/project/multichill/pyvenv/lib/python3.11/site-packages/urllib3/connectionpool.py:1103:
InsecureRequestWarning: Unverified HTTPS request is being made to host
'd3d00swyhr67nd.cloudfront.net'. Adding certificate verification is strongly
advised. See:
https://urllib3.readthedocs.io/en/latest/advanced-usage.html#tls-warnings\n
warnings.warn(\n"
Arguments: ()
Code that triggers it:
https://github.com/multichill/toollabs/blob/master/bot/commons/wikidata_uploader.py#L283
Assertion is at
https://doc.wikimedia.org/pywikibot/stable/_modules/tools/_logging.html#LoggingFormatter
This should not trigger a logging error
**Software version** (on `Special:Version` page; skip for WMF-hosted wikis
like Wikipedia):
commit 8eed00b944042033a42f322355311db890a277de (HEAD -> master,
origin/master, origin/HEAD)
Merge: 1e37bd943 83197e14a
Author: jenkins-bot <[email protected]>
Date: Sun Nov 10 09:04:43 2024 +0000
Merge "tests: fix TestItemLoad tests after the label was changed"
Which is quite old, I'll update and see if it is still giving errors.
TASK DETAIL
https://phabricator.wikimedia.org/T393957
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Multichill
Cc: Xqt, Aklapper, pywikibot-bugs-list, Multichill, mevo, PotsdamLamb,
Jyoo1011, JohnsonLee01, SHEKH, Dijkstra, Khutuck, Zkhalido, Aram, Viztor,
Wenyi, Tbscho, MayS, Mdupont, JJMC89, Dvorapa, Altostratus, Avicennasis,
Hannolans, mys_721tx, jayvdb, Masti, Alchimista
_______________________________________________
pywikibot-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
