Xqt added a comment.

  In T398146#10958283 <https://phabricator.wikimedia.org/T398146#10958283>, 
@Huji wrote:
  
  > 
  
  
  
  > The action item would be to edit the translitartion module 
<https://doc.wikimedia.org/pywikibot/master/_modules/userinterfaces/transliteration.html#NON_LATIN_DIGITS>
 to rename `NON_LATIN_DIGITS` to something more appropriate such as 
`NON_ARABIC_NUMERALS` or `ALTERNATE_NUMERALS`, keep `NON_LATIN_DIGITS` for a 
while as a deprecated constant and show a deprecation warning for it, update 
all pywikibot code that references `NON_LATIN_DIGITS` to reference the new 
constant (there are only a handful 
<https://codesearch.wmcloud.org/search/?q=NON_LATIN_DIGITS&files=&excludeFiles=&repos=#Pywikibot>),
 and ping the toolforge tools that are referencing `NON_LATIN_DIGITS` to also 
update their code (only a dozen or so changes 
<https://codesearch.wmcloud.org/search/?q=NON_LATIN_DIGITS&files=&excludeFiles=&repos=>).
  
  Good catch. Also the textlib.to_latin_digits 
<https://doc.wikimedia.org/pywikibot/master/api_ref/textlib.html#textlib.to_latin_digits>
 should be renamed then. We also can say ASCII digits 
<https://en.wikipedia.org/wiki/List_of_Unicode_characters> and curious enought 
they are part of the Basic Latin Unicode Block 
<https://en.wikipedia.org/wiki/Basic_Latin_(Unicode_block)>

TASK DETAIL
  https://phabricator.wikimedia.org/T398146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

_______________________________________________
pywikibot-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to