bd808 added a comment.
In T408721#11328181 <https://phabricator.wikimedia.org/T408721#11328181>, @Tgr wrote: > The change was meant for OAuth 2 access tokens (which weren't very consistent in what issuer was used, anyway), they generally don't share code with the OAuth 1 `/identify` tokens mwoauth cares about but apparently issuer generation is one of the few bits that's shared (they both use UserStatementProvider). I guess we should just revert that; conceptually I think meta as issuer makes more sense but OAuth 1 is a legacy protocol and we should probably avoid changes to it. I don't have strong opinions one way or another about the payload `iss`uer value, but I very much agree that a breaking change to the OAuth 1a legacy workflow should be avoided as much as is reasonably possible. If the mwoauth implementation breaks an unspecified but large number of tools will break. Even if the library is updated and pywikibot is updated to require the newer library there will be a very long tail of Python tools that will need to be contacted to force library upgrades (all pywikibot tools included). TASK DETAIL https://phabricator.wikimedia.org/T408721 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
_______________________________________________ pywikibot-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
