Andrybak created this task.
Andrybak added a project: Pywikibot.
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION
  **Steps to replicate the issue**:
  
  - Install/upgrade/downgrade to pywikibot 10.7.1 or 10.7.2
  - Configure pywikibot using the instructions from 
https://www.mediawiki.org/wiki/Manual:Pywikibot/BotPasswords
  - Use the following entry in the password file (generated using 
`Special:BotPasswords`, specifically `Special:BotPasswords/AndrybakBot` in this 
case):
  
    ('family_id', 'AndrybakBot', BotPassword('AndrybakBot', 
'11111111111111111111111111111111'))
  
  - Ensure we're not using tokens from previous login:
  
    python pwb.py login -logout
  
  - Run:
  
    python pwb.py login
  
  **What happens?**:
  After `python pwb.py login`
  
      File "<redacted>/core_stable/pywikibot/login.py", line 291, in 
readPassword
        entry = (entry[0], BotPassword(*entry[1]))
                           ^^^^^^^^^^^^^^^^^^^^^^
    TypeError: BotPassword.__init__() takes 3 positional arguments but 12 were 
given
    CRITICAL: Exiting due to uncaught exception TypeError: 
BotPassword.__init__() takes 3 positional arguments but 12 were given
  
  - I added some debug output to `pywikibot/login.py` just before the failing 
line, which gave me the following information:
    - `entry[0]` is `family_id`, which is whatever
    - but `entry[1]` is `AndrybakBot`, which is unexpected in the constructor 
of `BotPassword`
  
  **What should have happened instead?**:
  Successful logging in, something like:
  
    Logging in to family_id:en as AndrybakBot@AndrybakBot
    Logged in on family_id:en as AndrybakBot.
    
    Execution time: 2 seconds
  
  **Other information**
  
  - I've successfully used this password file since May 2021 without changes, 
and noticed the failure after upgrading pywikibot.
  - Cannot reproduce on version **10.7.0**.
  - `git blame` suggest that the root cause was the changes in T410753 
<https://phabricator.wikimedia.org/T410753>.

TASK DETAIL
  https://phabricator.wikimedia.org/T412074

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

_______________________________________________
pywikibot-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to