Xqt created this task. Xqt added projects: Pywikibot, Pywikibot-cosmetic-changes, good first task. Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. Restricted Application added a comment.
Thank you for tagging this task with #good_first_task <https://phabricator.wikimedia.org/tag/good_first_task/> for Wikimedia newcomers! Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects. A #good_first_task <https://phabricator.wikimedia.org/tag/good_first_task/> is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ ! Thank you for helping us drive new contributions to our projects <3 TASK DESCRIPTION **Current behaviour** Currently `CosmeticChangesToolkit.commonsfiledesc` method is available for `commons:commons` site only **Expected behaviour** The mehtod should be available for other sites of the commons Family too like `commons:test` or `commons:beta` **Way to go** Instead using the sitename method in commonsfiledesc if self.site.sitename() != u'commons:commons' ... use the family name instead: `self.site.family.name` which is `commons`. **See also** - commonsfiledesc method <https://doc.wikimedia.org/pywikibot/master/api_ref/cosmetic_changes.html#cosmetic_changes.CosmeticChangesToolkit.commonsfiledesc> - Commons Family <https://doc.wikimedia.org/pywikibot/master/api_ref/pywikibot.families.html#module-families.commons_family> - Pywikibot Development <https://www.mediawiki.org/wiki/Manual:Pywikibot/Development> TASK DETAIL https://phabricator.wikimedia.org/T425349 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
_______________________________________________ pywikibot-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
