jenkins-bot has submitted this change and it was merged.

Change subject: pep8 changes
......................................................................


pep8 changes

Change-Id: I4cf67a6b69a0a34b5dd2ebf9ef21904b6c3af563
---
M template.py
1 file changed, 16 insertions(+), 12 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/template.py b/template.py
index 2fdb4ef..677890f 100644
--- a/template.py
+++ b/template.py
@@ -105,12 +105,16 @@
 #
 __version__='$Id$'
 #
-import re, sys, string
+import re
+import sys
+import string
 import wikipedia as pywikibot
 from pywikibot import i18n
-import config, catlib
+import config
+import catlib
 import pagegenerators as pg
 import replace
+
 
 def UserEditFilterGenerator(generator, username, timestamp=None, skip=False):
     """
@@ -153,15 +157,14 @@
             * templateNames - A list of Page object representing the searched
                               templates
             * xmlfilename   - The dump's path, either absolute or relative
+
         """
 
         self.templates = templates
         self.xmlfilename = xmlfilename
 
     def __iter__(self):
-        """
-        Yield page objects until the entire XML dump has been read.
-        """
+        """Yield page objects until the entire XML dump has been read."""
         import xmlreader
         mysite = pywikibot.getSite()
         dump = xmlreader.XmlDump(self.xmlfilename)
@@ -189,9 +192,10 @@
     This robot will load all pages yielded by a page generator and replace or
     remove all occurences of the old template, or substitute them with the
     template's text.
+
     """
-    def __init__(self, generator, templates, subst = False, remove = False,
-                 editSummary = '', acceptAll = False, addedCat = None):
+    def __init__(self, generator, templates, subst=False, remove=False,
+                 editSummary='', acceptAll=False, addedCat=None):
         """
         Arguments:
             * generator    - A page generator.
@@ -201,6 +205,7 @@
                              removed/resolved to None.
             * remove       - True if the template should be removed.
             * subst        - True if the template should be resolved.
+
         """
         self.generator = generator
         self.templates = templates
@@ -217,7 +222,7 @@
         comma = self.summary = site.mediawiki_message('comma-separator')
 
         # get edit summary message if it's empty
-        if (self.editSummary==''):
+        if not self.editSummary:
             Param = {'list': comma.join(self.templates.keys()),
                      'num' : len(self.templates)}
             if self.remove:
@@ -231,9 +236,7 @@
                     site, 'template-changing', Param)
 
     def run(self):
-        """
-        Starts the robot's action.
-        """
+        """Starts the robot's action."""
         # regular expression to find the original template.
         # {{vfd}} does the same thing as {{Vfd}}, so both will be found.
         # The old syntax, {{msg:vfd}}, will also be found.
@@ -277,6 +280,7 @@
                                           addedCat=self.addedCat,
                                           editSummary=self.editSummary)
         replaceBot.run()
+
 
 def main(*args):
     templateNames = []
@@ -355,7 +359,7 @@
                 for t in oldTemplates]
         gen = pg.CombinedPageGenerator(gens)
         gen = pg.DuplicateFilterPageGenerator(gen)
-        
+
     preloadingGen = pg.PreloadingGenerator(gen)
     bot = TemplateRobot(preloadingGen, templates, subst, remove, editSummary,
                         acceptAll, addedCat)

-- 
To view, visit https://gerrit.wikimedia.org/r/78674
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4cf67a6b69a0a34b5dd2ebf9ef21904b6c3af563
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/compat
Gerrit-Branch: master
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits

Reply via email to