jenkins-bot has submitted this change and it was merged.

Change subject: pyflakes and bugfixes
......................................................................


pyflakes and bugfixes

remove obsolete sys import
fix unknown response variable
use weblink as imported instead of pywikibot.weblib

Change-Id: I78f5ba1829a634b0518223bf4ff7cf1d5a266556
---
M scripts/weblinkchecker.py
1 file changed, 3 insertions(+), 5 deletions(-)

Approvals:
  Ladsgroup: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/scripts/weblinkchecker.py b/scripts/weblinkchecker.py
index 1269378..8843286 100644
--- a/scripts/weblinkchecker.py
+++ b/scripts/weblinkchecker.py
@@ -99,7 +99,6 @@
 #
 __version__ = '$Id$'
 
-import sys
 import re
 import codecs
 import pickle
@@ -273,8 +272,7 @@
                 conn = self.getConnection()
                 conn.request('HEAD', '/', None, self.header)
                 self.response = conn.getresponse()
-
-                self.readEncodingFromResponse(response)
+                self.readEncodingFromResponse(self.response)
             except:
                 pass
             if not self.serverEncoding:
@@ -592,9 +590,9 @@
             # We'll list it in a file so that it can be removed manually.
             if timeSinceFirstFound > 60 * 60 * 24 * day:
                 # search for archived page
-                archiveURL = pywikibot.weblib.getInternetArchiveURL(url)
+                archiveURL = weblib.getInternetArchiveURL(url)
                 if archiveURL is None:
-                    archiveURL = pywikibot.weblib.getWebCitationURL(url)
+                    archiveURL = weblib.getWebCitationURL(url)
                 self.log(url, error, page, archiveURL)
         else:
             self.historyDict[url] = [(page.title(), now, error)]

-- 
To view, visit https://gerrit.wikimedia.org/r/119295
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I78f5ba1829a634b0518223bf4ff7cf1d5a266556
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits

Reply via email to