jenkins-bot has submitted this change and it was merged.
Change subject: Remove pwb installation from setup.py
......................................................................
Remove pwb installation from setup.py
setup.py install is run by pip or directly by the user to install
a package, typically into a system wide location. As this is a
system wide operation, it should not be followed by a per-user
configuration task like calling generate_user_files.py,
especially as it requires user interaction.
As a installed library, pywikibot should avoid requiring user
configuration files.
Change-Id: Ibcab9f783cbe8299f104c690466be32e22aa4c1a
---
M setup.py
1 file changed, 0 insertions(+), 20 deletions(-)
Approvals:
John Vandenberg: Looks good to me, but someone else must approve
Merlijn van Deen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/setup.py b/setup.py
index 83a2119..1baafb7 100644
--- a/setup.py
+++ b/setup.py
@@ -85,23 +85,6 @@
use_setuptools()
from setuptools import setup, find_packages
-from setuptools.command import install
-
-
-class pwb_install(install.install):
-
- """
- Setuptools' install command subclassed to automatically call
- `generate_user_files.py` after installing the package.
- """
- def run(self):
- install.install.do_egg_install(self)
-
- if sys.stdin.isatty() and sys.stdout.isatty():
- import subprocess
- python = sys.executable
- python = python.replace("pythonw.exe", "python.exe") # for Windows
- subprocess.call([python, "generate_user_files.py"])
name = 'pywikibot'
version = '2.0b2'
@@ -135,8 +118,5 @@
'Environment :: Console',
'Programming Language :: Python :: 2.7'
],
- cmdclass={
- 'install': pwb_install
- },
use_2to3=False
)
--
To view, visit https://gerrit.wikimedia.org/r/170308
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcab9f783cbe8299f104c690466be32e22aa4c1a
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
