jenkins-bot has submitted this change and it was merged.
Change subject: Remove unused Family.content_id
......................................................................
Remove unused Family.content_id
content_id is used in compat, for non-API access to mediawiki, which
is functionality that exists in core.
If core ever needs to support pre-1.13 editing, this and many other
parts of compat will need to be extensively mined for implementation
details like this. We know where to find this. It doesnt need to
be in core Family.
Change-Id: Ib3111eba7c16782a68646f34b540062486e17e6e
---
M pywikibot/families/wowwiki_family.py
M pywikibot/family.py
2 files changed, 0 insertions(+), 7 deletions(-)
Approvals:
John Vandenberg: Looks good to me, but someone else must approve
Nullzero: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/families/wowwiki_family.py
b/pywikibot/families/wowwiki_family.py
index 6aa1ebf..fbf820e 100644
--- a/pywikibot/families/wowwiki_family.py
+++ b/pywikibot/families/wowwiki_family.py
@@ -49,8 +49,6 @@
'zh': 'zh.wow.wikia.com'
}
- self.content_id = "article"
-
self.disambiguationTemplates['en'] = ['disambig', 'disambig/quest',
'disambig/quest2',
'disambig/achievement2']
diff --git a/pywikibot/family.py b/pywikibot/family.py
index b3941ff..2a659e0 100644
--- a/pywikibot/family.py
+++ b/pywikibot/family.py
@@ -259,11 +259,6 @@
'zea': u'[a-zäöüïëéèà]*',
}
- # Wikimedia wikis all use "bodyContent" as the id of the <div>
- # element that contains the actual page content; change this for
- # wikis that use something else (e.g., mozilla family)
- self.content_id = "bodyContent"
-
# A dictionary where keys are family codes that can be used in
# inter-family interwiki links. Do not use it directly but
# get_known_families() instead.
--
To view, visit https://gerrit.wikimedia.org/r/170683
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3111eba7c16782a68646f34b540062486e17e6e
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: Nullzero <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits