jenkins-bot has submitted this change and it was merged.
Change subject: [FIX] pagegen tests: apply case sensitivity
......................................................................
[FIX] pagegen tests: apply case sensitivity
When the pagegenerator tests are done with case sensitive namespaces the
tests failed because the title read from the file were lowercase but the
test expected uppercase. This adds the expected results for both case
sensitivity settings.
Also added an test with an explicit uppercase value that those page
doesn't get lowercased by accident.
Change-Id: Ica76e5218f9301b76b537d9c532f8c6c8fac85f7
---
M tests/data/pagelist-brackets.txt
M tests/data/pagelist-lines.txt
M tests/pagegenerators_tests.py
3 files changed, 10 insertions(+), 4 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
XZise: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/tests/data/pagelist-brackets.txt b/tests/data/pagelist-brackets.txt
index 6c7ef0f..5035ef7 100644
--- a/tests/data/pagelist-brackets.txt
+++ b/tests/data/pagelist-brackets.txt
@@ -1,5 +1,5 @@
[[file]] [[bracket]]
[[MediaWiki:Test|foo]] with
-[[under_score]]
+[[under_score]], [[Upper case]]
and
text.
diff --git a/tests/data/pagelist-lines.txt b/tests/data/pagelist-lines.txt
index 4f8ad01..8b58e2f 100644
--- a/tests/data/pagelist-lines.txt
+++ b/tests/data/pagelist-lines.txt
@@ -2,3 +2,4 @@
bracket
MediaWiki:Test|foo
under_score
+Upper case
diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 0ce3bba..81720d1 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -250,19 +250,24 @@
dry = True
- expected_titles = ('File', 'Bracket', 'MediaWiki:Test', 'Under score')
+ expected_titles = {
+ 'case-sensitive': ('file', 'bracket', 'MediaWiki:Test',
+ 'under score', 'Upper case'),
+ 'first-letter': ('File', 'Bracket', 'MediaWiki:Test', 'Under score',
+ 'Upper case'),
+ }
def test_brackets(self):
filename = os.path.join(_data_dir, 'pagelist-brackets.txt')
site = self.get_site()
titles = list(pagegenerators.TextfilePageGenerator(filename, site))
- self.assertPagelistTitles(titles, self.expected_titles, site)
+ self.assertPagelistTitles(titles, self.expected_titles[site.case()])
def test_lines(self):
filename = os.path.join(_data_dir, 'pagelist-lines.txt')
site = self.get_site()
titles = list(pagegenerators.TextfilePageGenerator(filename, site))
- self.assertPagelistTitles(titles, self.expected_titles, site)
+ self.assertPagelistTitles(titles, self.expected_titles[site.case()])
class TestDequePreloadingGenerator(DefaultSiteTestCase):
--
To view, visit https://gerrit.wikimedia.org/r/172576
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica76e5218f9301b76b537d9c532f8c6c8fac85f7
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: XZise <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
