jenkins-bot has submitted this change and it was merged.
Change subject: [FIX] ParamInfo: Don't modify module set
......................................................................
[FIX] ParamInfo: Don't modify module set
The module set has been modified which led to the effect that when
someone was fetching all entries and then iterating over the entries of
the same set, that all already cached entries were missing from the set.
The HTTP GET patch (c26b9dcb4242add0145a883c6b6973a45a665ed0) therefore
was thinking it could use a GET request, because the entry which
should've shown it that a POST request is required was deleted.
Change-Id: I467ff7a8fe243df0abd7f322ecaa8460a91e4017
---
M pywikibot/data/api.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Merlijn van Deen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/data/api.py b/pywikibot/data/api.py
index 3eb69a1..8aa97b4 100644
--- a/pywikibot/data/api.py
+++ b/pywikibot/data/api.py
@@ -274,7 +274,7 @@
else:
modules = set(modules)
- modules -= set(self._paraminfo.keys())
+ modules = modules - set(self._paraminfo.keys())
if not modules:
return
--
To view, visit https://gerrit.wikimedia.org/r/173631
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I467ff7a8fe243df0abd7f322ecaa8460a91e4017
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
