jenkins-bot has submitted this change and it was merged.
Change subject: [FIX] Update buffered Siteinfo value
......................................................................
[FIX] Update buffered Siteinfo value
The old value didn't contained the manually added value so now always fails.
After adding it to the cache it should update the old value.
Change-Id: I618d7d129a1d1ebba2fdcc52fd5c0ef2b40aedb0
---
M tests/site_tests.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/site_tests.py b/tests/site_tests.py
index e082edf..86af273 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -92,7 +92,8 @@
# content also changes so force that the content changes
self.assertNotIn('DUMMY', old)
self.site.siteinfo._cache['general'][0]['DUMMY'] = 42
- self.assertIn('DUMMY', self.site.siteinfo('general'))
+ old = self.site.siteinfo('general')
+ self.assertIn('DUMMY', old)
self.assertNotEqual(self.site.siteinfo('general', force=True), old)
self.assertDeprecation('Calling siteinfo is deprecated, use itself
instead.')
--
To view, visit https://gerrit.wikimedia.org/r/218533
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I618d7d129a1d1ebba2fdcc52fd5c0ef2b40aedb0
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
