jenkins-bot has submitted this change and it was merged.
Change subject: Remove FIXME from APISite.loadflowinfo
......................................................................
Remove FIXME from APISite.loadflowinfo
As APISite.loadflowinfo is deprecated, and this FIXME would require
changing the exception raised from APIError to UnknownException,
it is better to leave it and document the existing behaviour.
Change-Id: I3df9f67edc252069192efcdfda0a12262189ef0c
---
M pywikibot/site.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
John Vandenberg: Looks good to me, approved
XZise: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/pywikibot/site.py b/pywikibot/site.py
index eae3500..deabf6a 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -2494,7 +2494,9 @@
"""
Load Flow-related information about a given page.
- FIXME: Assumes that the Flow extension is installed.
+ Assumes that the Flow extension is installed.
+
+ @raises APIError: Flow extension is not installed
"""
title = page.title(withSection=False)
query = self._generator(api.PropertyGenerator,
--
To view, visit https://gerrit.wikimedia.org/r/214024
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3df9f67edc252069192efcdfda0a12262189ef0c
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: XZise <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
