jenkins-bot has submitted this change and it was merged.
Change subject: Remove causes of DeprecationWarning in page.py/site.py
......................................................................
Remove causes of DeprecationWarning in page.py/site.py
Replaced Page.getVersionHistory() with Page.revisions().
Used new Request() signature (with parameters) in
Site.mediawiki_messages() (added in b44e59ae)
Change-Id: Ie88517f523e5d01c76a81bd3cbf284f284da3337
---
M pywikibot/page.py
M pywikibot/site.py
2 files changed, 6 insertions(+), 7 deletions(-)
Approvals:
XZise: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/page.py b/pywikibot/page.py
index 2c49270..9aef0b0 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -593,7 +593,7 @@
return self._lastNonBotUser
self._lastNonBotUser = None
- for entry in self.getVersionHistory():
+ for entry in self.revisions():
if entry.user and (not self.site.isBot(entry.user)):
self._lastNonBotUser = entry.user
break
diff --git a/pywikibot/site.py b/pywikibot/site.py
index 4d3e34c..572455c 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -1985,12 +1985,11 @@
@return: dict
"""
if not all(_key in self._msgcache for _key in keys):
- msg_query = api.QueryGenerator(
- site=self,
- meta="allmessages",
- ammessages='|'.join(keys),
- amlang=self.lang,
- )
+ parameters = {'meta': 'allmessages',
+ 'ammessages': keys,
+ 'amlang': self.lang,
+ }
+ msg_query = api.QueryGenerator(site=self, parameters=parameters)
for msg in msg_query:
if 'missing' not in msg:
--
To view, visit https://gerrit.wikimedia.org/r/218502
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie88517f523e5d01c76a81bd3cbf284f284da3337
Gerrit-PatchSet: 5
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Mpaa <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: Mpaa <[email protected]>
Gerrit-Reviewer: XZise <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
