jenkins-bot has submitted this change and it was merged.

Change subject: Multi site family detection regression
......................................................................


Multi site family detection regression

53141af26 migrated the site detection logic from
generate_family_file.py to pywikibot.site_detect.MWSite.
(Merlijn van Deen was Author: for attribution only)

This introduced an error as MWSite.langs failed, preventing
multi site family from being detected, and thus always
creating a single site family.

Bug: T74846
Change-Id: I157c2b48cf49dcc7b94eca439f6f3d3e45bd969e
---
M pywikibot/site_detect.py
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  XZise: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/pywikibot/site_detect.py b/pywikibot/site_detect.py
index 7dd2587..23e3c22 100644
--- a/pywikibot/site_detect.py
+++ b/pywikibot/site_detect.py
@@ -102,9 +102,8 @@
         if 'error' in iw:
             raise RuntimeError('%s - %s' % (iw['error']['code'],
                                             iw['error']['info']))
-        self.langs = [wiki for wiki in iw['query']['interwikimap']
-                      if u'language' in wiki]
-        return self.langs
+        return [wiki for wiki in iw['query']['interwikimap']
+                if u'language' in wiki]
 
     def _parse_pre_117(self, data):
         """Parse HTML."""

-- 
To view, visit https://gerrit.wikimedia.org/r/235662
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I157c2b48cf49dcc7b94eca439f6f3d3e45bd969e
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: XZise <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits

Reply via email to