jenkins-bot has submitted this change and it was merged.
Change subject: Fix meta test name generator
......................................................................
Fix meta test name generator
Allow site code line 'zh-yue', converting it to 'zh_yue'.
Also use FIXME in archivebot_tests.
Bug: T112491
Change-Id: I1abd89b1f56b25b3ab546bf9c6e3b3606cdf5f09
---
M tests/archivebot_tests.py
M tests/aspects.py
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
John Vandenberg: Looks good to me, but someone else must approve
XZise: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/archivebot_tests.py b/tests/archivebot_tests.py
index 819faf1..edcfdce 100644
--- a/tests/archivebot_tests.py
+++ b/tests/archivebot_tests.py
@@ -78,7 +78,7 @@
raise
expected_failures = ['ar', 'pdc', 'th']
- # expected failures - should be fixed
+ # FIXME:
# 'ar': Uses Arabic acronym for TZ
# 'pdc': changed month name setting in wiki over time (?)
# in old posts in talk page, February is "Feb.", site message gives
diff --git a/tests/aspects.py b/tests/aspects.py
index 1add9e2..991a140 100644
--- a/tests/aspects.py
+++ b/tests/aspects.py
@@ -837,7 +837,7 @@
# create test methods processed by unittest
for (key, sitedata) in dct['sites'].items():
- test_name = test + '_' + key
+ test_name = test + '_' + key.replace('-', '_')
dct[test_name] = wrap_method(key, sitedata, dct[test])
--
To view, visit https://gerrit.wikimedia.org/r/238088
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1abd89b1f56b25b3ab546bf9c6e3b3606cdf5f09
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: XZise <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
