jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/464609 )
Change subject: [CLEANUP] Cleanup pywikibot/data/ files
......................................................................
[CLEANUP] Cleanup pywikibot/data/ files
- use str.format(...) for type specifier arguments.
- use "+" to concatenate strings in some cases.
Change-Id: I48ec2c04c66576e8492f262c061c878f1e16a550
---
M pywikibot/data/mysql.py
M pywikibot/data/sparql.py
M pywikibot/data/wikistats.py
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Dvorapa: Looks good to me, but someone else must approve
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/data/mysql.py b/pywikibot/data/mysql.py
index 193c9a7..ebe5063 100644
--- a/pywikibot/data/mysql.py
+++ b/pywikibot/data/mysql.py
@@ -89,7 +89,7 @@
_query = UnicodeType(_query, encoding='utf-8')
_query = _query.strip()
_query = '\n'.join(' {0}'.format(l) for l in _query.splitlines())
- pywikibot.output('Executing query:\n%s' % _query)
+ pywikibot.output('Executing query:\n' + _query)
cursor.execute(query, params)
diff --git a/pywikibot/data/sparql.py b/pywikibot/data/sparql.py
index 3c602c2..9b9eb0e 100644
--- a/pywikibot/data/sparql.py
+++ b/pywikibot/data/sparql.py
@@ -141,7 +141,7 @@
@param query: Query text
@type query: string
"""
- url = '%s?query=%s' % (self.endpoint, quote(query))
+ url = '{0}?query={1}'.format(self.endpoint, quote(query))
while True:
try:
self.last_response = http.fetch(url, headers=headers)
diff --git a/pywikibot/data/wikistats.py b/pywikibot/data/wikistats.py
index f637f71..a70844b 100644
--- a/pywikibot/data/wikistats.py
+++ b/pywikibot/data/wikistats.py
@@ -107,7 +107,7 @@
url = self.url + path
if table not in self.ALL_KEYS:
- pywikibot.warning('WikiStats unknown table %s' % table)
+ pywikibot.warning('WikiStats unknown table ' + table)
if table in self.FAMILY_MAPPING:
table = self.FAMILY_MAPPING[table]
--
To view, visit https://gerrit.wikimedia.org/r/464609
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I48ec2c04c66576e8492f262c061c878f1e16a550
Gerrit-Change-Number: 464609
Gerrit-PatchSet: 9
Gerrit-Owner: D3r1ck01 <[email protected]>
Gerrit-Reviewer: D3r1ck01 <[email protected]>
Gerrit-Reviewer: Dalba <[email protected]>
Gerrit-Reviewer: Dvorapa <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot (75)
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
