jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/478485 )
Change subject: [bugfix] Fix upload.py breaking with url and description
containing ":"
......................................................................
[bugfix] Fix upload.py breaking with url and description containing ":"
Change-Id: I68ea492f02ba510b3b8d27d5962e3a98a741b41b
---
M scripts/upload.py
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Dvorapa: Looks good to me, but someone else must approve
D3r1ck01: Looks good to me, but someone else must approve
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/upload.py b/scripts/upload.py
index fed6924..3750bb2 100755
--- a/scripts/upload.py
+++ b/scripts/upload.py
@@ -154,11 +154,10 @@
chunk_size = get_chunk_size(match)
elif arg == '-descfile':
description_file = value
- elif arg and not value:
- if not url:
- url = arg
- else:
- description.append(arg)
+ elif not url:
+ url = option
+ else:
+ description.append(option)
description = ' '.join(description)
--
To view, visit https://gerrit.wikimedia.org/r/478485
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I68ea492f02ba510b3b8d27d5962e3a98a741b41b
Gerrit-Change-Number: 478485
Gerrit-PatchSet: 4
Gerrit-Owner: Maze <[email protected]>
Gerrit-Reviewer: D3r1ck01 <[email protected]>
Gerrit-Reviewer: Dvorapa <[email protected]>
Gerrit-Reviewer: Framawiki <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: Maze <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot (75)
Gerrit-CC: Welcome, new contributor! <[email protected]>
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
