jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/524499 )
Change subject: [cleanup] Nothing left to do for a deprecated method
......................................................................
[cleanup] Nothing left to do for a deprecated method
Also update the README-conversion.txt file.
Change-Id: I8846ed1f6a483e74813bbfa97e32d424afe5fecf
---
M README-conversion.txt
M pywikibot/page.py
2 files changed, 2 insertions(+), 3 deletions(-)
Approvals:
Zhuyifei1999: Looks good to me, approved
jenkins-bot: Verified
diff --git a/README-conversion.txt b/README-conversion.txt
index e127cc5..f78bb09 100644
--- a/README-conversion.txt
+++ b/README-conversion.txt
@@ -110,8 +110,8 @@
The old ImagePage class has been renamed into FilePage.
For FilePage objects, the getFileMd5Sum() method is deprecated; it is
-recommended to replace it with getFileSHA1Sum(), because MediaWiki now
-stores the SHA1 hash of images.
+recommended to replace it with latest_file_info.sha1 property because
+MediaWiki now stores the SHA1 hash of images.
=== Category objects ===
diff --git a/pywikibot/page.py b/pywikibot/page.py
index 59964df..893c512 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -2605,7 +2605,6 @@
@deprecated('FilePage.latest_file_info.sha1', since='20141106')
def getFileMd5Sum(self):
"""Return image file's MD5 checksum."""
- # TODO: check whether this needs a User-Agent header added
req = http.fetch(self.fileUrl())
h = hashlib.md5()
h.update(req.raw)
--
To view, visit https://gerrit.wikimedia.org/r/524499
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8846ed1f6a483e74813bbfa97e32d424afe5fecf
Gerrit-Change-Number: 524499
Gerrit-PatchSet: 3
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: John Vandenberg <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: Zhuyifei1999 <[email protected]>
Gerrit-Reviewer: jenkins-bot (75)
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
