jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/610774 )
Change subject: [bugfix] remove expectedFailure decorator of test_ecoreality
......................................................................
[bugfix] remove expectedFailure decorator of test_ecoreality
Bug: T257559
Change-Id: Ic2672416b0dd7bb7f7a734a004edf61c870f7112
---
M tests/site_detect_tests.py
1 file changed, 3 insertions(+), 12 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/site_detect_tests.py b/tests/site_detect_tests.py
index 0eab946..bdabad2 100644
--- a/tests/site_detect_tests.py
+++ b/tests/site_detect_tests.py
@@ -5,25 +5,19 @@
#
# Distributed under the terms of the MIT license.
#
-
-from __future__ import absolute_import, division, unicode_literals
+from contextlib import suppress
+from urllib.parse import urlparse
from requests.exceptions import ConnectionError, Timeout
import pywikibot
from pywikibot.exceptions import ServerError
from pywikibot.site_detect import MWSite
-from pywikibot.tools import PY2
from tests import unittest_print
from tests.aspects import unittest, TestCase, PatchingTestCase
from tests.utils import DrySite
-if not PY2:
- from urllib.parse import urlparse
-else:
- from urlparse import urlparse
-
class SiteDetectionTestCase(TestCase):
@@ -161,7 +155,6 @@
"""
self.assertNoSite('http://wikisophia.org/index.php?title=$1')
- @unittest.expectedFailure
def test_ecoreality(self):
"""Test detection of MediaWiki sites for www.EcoReality.org.
@@ -345,7 +338,5 @@
if __name__ == '__main__': # pragma: no cover
- try:
+ with suppress(SystemExit):
unittest.main()
- except SystemExit:
- pass
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/610774
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ic2672416b0dd7bb7f7a734a004edf61c870f7112
Gerrit-Change-Number: 610774
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
