jenkins-bot has submitted this change. ( 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611296 )

Change subject: [IMPR] prohibit positional arguments with Page.title()
......................................................................

[IMPR] prohibit positional arguments with Page.title()

It is not usefull to use Page.title() with positional arguments.
Prohibit this by new Python 3.5 functionality and force explicit
usage of parameters

Change-Id: Id6a0911c4a21702d19f8837a8da090a020dbbb70
---
M pywikibot/page/__init__.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  JJMC89: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/pywikibot/page/__init__.py b/pywikibot/page/__init__.py
index c8f678b..54695ec 100644
--- a/pywikibot/page/__init__.py
+++ b/pywikibot/page/__init__.py
@@ -282,7 +282,7 @@
         decode=True, savetitle='as_url', withNamespace='with_ns',
         withSection='with_section', forceInterwiki='force_interwiki',
         asUrl='as_url', asLink='as_link', allowInterwiki='allow_interwiki')
-    def title(self, underscore=False, with_ns=True,
+    def title(self, *, underscore=False, with_ns=True,
               with_section=True, as_url=False, as_link=False,
               allow_interwiki=True, force_interwiki=False, textlink=False,
               as_filename=False, insite=None, without_brackets=False) -> str:

--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/611296
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.wikimedia.org/r/settings

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Id6a0911c4a21702d19f8837a8da090a020dbbb70
Gerrit-Change-Number: 611296
Gerrit-PatchSet: 3
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: JJMC89 <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits

Reply via email to