jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/631964 )
Change subject: [bugfix] Check for a valid logtype in TestLogentries
......................................................................
[bugfix] Check for a valid logtype in TestLogentries
Bug: T264523
Change-Id: Ib4efde59e91058667c5b8eb4171ced3b609e0f4f
---
M tests/logentries_tests.py
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/logentries_tests.py b/tests/logentries_tests.py
index 942e5b0..a4d9a67 100644
--- a/tests/logentries_tests.py
+++ b/tests/logentries_tests.py
@@ -132,8 +132,10 @@
def test_method(logtype):
def test_logevent(self, key):
"""Test a single logtype entry."""
- if key == 'old' and logtype == 'thanks':
- self.skipTest('Thanks extension not on old.')
+ site = self.sites[key]['site']
+ if logtype not in site.logtypes:
+ self.skipTest('{}: "{}" logtype not available on {}.'
+ .format(key, logtype, site))
self._test_logevent(logtype)
return test_logevent
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/631964
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ib4efde59e91058667c5b8eb4171ced3b609e0f4f
Gerrit-Change-Number: 631964
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
