jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/638296 )
Change subject: [doc] Positional arguments of page.Revision must be replaced
......................................................................
[doc] Positional arguments of page.Revision must be replaced
Change-Id: I6941a6e5d731caa73edfe4017cbc905dfdeaa43f
---
M ROADMAP.rst
M pywikibot/page/_revision.py
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/ROADMAP.rst b/ROADMAP.rst
index b35bddd..e6c246c 100644
--- a/ROADMAP.rst
+++ b/ROADMAP.rst
@@ -8,6 +8,7 @@
Future release notes
~~~~~~~~~~~~~~~~~~~~
+* 5.1.0: Positional arguments of page.Revision must be replaced by keyword
arguments (T259428)
* 5.0.0: wikistats methods fetch, raw_cached, csv, xml will be removed
* 5.0.0: PageRelatedError.getPage() will be removes in favour of
PageRelatedError.page
* 5.0.0: HttpRequest result of http.fetch() will be replaced by
requests.Response (T265206)
diff --git a/pywikibot/page/_revision.py b/pywikibot/page/_revision.py
index 9331b46..8aa721f 100644
--- a/pywikibot/page/_revision.py
+++ b/pywikibot/page/_revision.py
@@ -48,7 +48,7 @@
)
# replace positional arguments with keyword arguments
- for i, (arg, key) in enumerate(zip(args, keys)):
+ for i, (arg, key) in enumerate(zip(args, keys)): # pragma: no cover
issue_deprecation_warning('Positional argument {} ({})'
.format(i + 1, arg),
'keyword argument "{}={}"'
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/638296
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I6941a6e5d731caa73edfe4017cbc905dfdeaa43f
Gerrit-Change-Number: 638296
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
