jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/655892 )
Change subject: [IMPR] Use need_right decorator to check required user right
......................................................................
[IMPR] Use need_right decorator to check required user right
Change-Id: Ic8da5864e365b8bc59d9432542c25a4cebbe8baf
---
M pywikibot/site/__init__.py
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Mpaa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/site/__init__.py b/pywikibot/site/__init__.py
index 348f34d..2cc9d63 100644
--- a/pywikibot/site/__init__.py
+++ b/pywikibot/site/__init__.py
@@ -4357,6 +4357,7 @@
return req.submit()['query']['stashimageinfo'][0]
@deprecate_arg('imagepage', 'filepage')
+ @need_right('upload')
def upload(self, filepage, source_filename=None, source_url=None,
comment=None, text=None, watch=False, ignore_warnings=False,
chunk_size: int = 0, _file_key: Optional[str] = None,
@@ -4448,11 +4449,6 @@
# An offset != 0 doesn't make sense without a file key
assert(_offset == 0 or _file_key is not None)
- # check for required user right
- if not self.has_right('upload'):
- raise Error(
- "User '%s' does not have upload rights on site %s."
- % (self.user(), self))
# check for required parameters
if bool(source_filename) == bool(source_url):
raise ValueError('APISite.upload: must provide either '
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/655892
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ic8da5864e365b8bc59d9432542c25a4cebbe8baf
Gerrit-Change-Number: 655892
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Mpaa <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
