jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/657607 )
Change subject: [tests] Test sites for identity in
TestSiteObject.test_constructors
......................................................................
[tests] Test sites for identity in TestSiteObject.test_constructors
- sites created by site.APISite.fromDBName() must be identical to sites
created by Site function because both of them uses pywikibot._sites
object cache
- use sitename for instantiating a site
Change-Id: Id613a6fe921cd5af3cdcdb6d81cb1051eab12ee1
---
M tests/site_tests.py
1 file changed, 14 insertions(+), 14 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/site_tests.py b/tests/site_tests.py
index dcb058f..316cffc 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -158,27 +158,27 @@
def test_constructors(self):
"""Test cases for site constructors."""
test_list = [
- ['enwiki', ('en', 'wikipedia')],
- ['eswikisource', ('es', 'wikisource')],
- ['dewikinews', ('de', 'wikinews')],
- ['ukwikivoyage', ('uk', 'wikivoyage')],
- ['metawiki', ('meta', 'meta')],
- ['commonswiki', ('commons', 'commons')],
- ['wikidatawiki', ('wikidata', 'wikidata')],
- ['testwikidatawiki', ('test', 'wikidata')],
- ['testwiki', ('test', 'wikipedia')], # see T225729, T228300
- ['test2wiki', ('test2', 'wikipedia')], # see T225729
- ['sourceswiki', ('mul', 'wikisource')], # see T226960
+ ['enwiki', 'wikipedia:en'],
+ ['eswikisource', 'wikisource:es'],
+ ['dewikinews', 'wikinews:de'],
+ ['ukwikivoyage', 'wikivoyage:uk'],
+ ['metawiki', 'meta:meta'],
+ ['commonswiki', 'commons:commons'],
+ ['wikidatawiki', 'wikidata:wikidata'],
+ ['testwikidatawiki', 'wikidata:test'],
+ ['testwiki', 'wikipedia:test'], # see T225729, T228300
+ ['test2wiki', 'wikipedia:test2'], # see T225729
+ ['sourceswiki', 'wikisource:mul'], # see T226960
]
if isinstance(self.site.family, pywikibot.family.WikimediaFamily):
site = self.site
else:
site = None
- for dbname, site_tuple in test_list:
+ for dbname, sitename in test_list:
with self.subTest(dbname=dbname):
- self.assertEqual(
+ self.assertIs(
pywikibot.site.APISite.fromDBName(dbname, site),
- pywikibot.Site(*site_tuple))
+ pywikibot.Site(sitename))
def test_language_methods(self):
"""Test cases for languages() and related methods."""
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/657607
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Id613a6fe921cd5af3cdcdb6d81cb1051eab12ee1
Gerrit-Change-Number: 657607
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-commits
