jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/750464 )
Change subject: [cleanup] remove unnecessary 'else' used after 'return'
......................................................................
[cleanup] remove unnecessary 'else' used after 'return'
Change-Id: I62fa554417072ed7b0f52a3b4aea29fcc03fa544
---
M pywikibot/login.py
M pywikibot/page/_collections.py
M pywikibot/tools/__init__.py
3 files changed, 3 insertions(+), 6 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/login.py b/pywikibot/login.py
index 5b61959..79782ae 100644
--- a/pywikibot/login.py
+++ b/pywikibot/login.py
@@ -424,8 +424,7 @@
pywikibot.error(e)
if retry:
return self.login(retry=True, force=force)
- else:
- return False
+ return False
else:
pywikibot.output('Logged in to {site} via consumer {key}'
.format(key=self.consumer_token[0],
diff --git a/pywikibot/page/_collections.py b/pywikibot/page/_collections.py
index a8dae47..7cd7c4a 100644
--- a/pywikibot/page/_collections.py
+++ b/pywikibot/page/_collections.py
@@ -87,8 +87,7 @@
"""Construct a new LanguageDict from JSON."""
if data != []: # workaround for T222159
return cls({key: value['value'] for key, value in data.items()})
- else:
- return cls()
+ return cls()
@classmethod
def normalizeData(cls, data: dict):
diff --git a/pywikibot/tools/__init__.py b/pywikibot/tools/__init__.py
index 9870d16..981a488 100644
--- a/pywikibot/tools/__init__.py
+++ b/pywikibot/tools/__init__.py
@@ -519,8 +519,7 @@
if self.version != other.version:
return self.version < other.version
- else:
- return self._dev_version < other._dev_version
+ return self._dev_version < other._dev_version
class RLock:
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/750464
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I62fa554417072ed7b0f52a3b4aea29fcc03fa544
Gerrit-Change-Number: 750464
Gerrit-PatchSet: 2
Gerrit-Owner: Zabe <alexander.vorw...@stud.uni-goettingen.de>
Gerrit-Reviewer: Xqt <i...@gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list -- pywikibot-commits@lists.wikimedia.org
To unsubscribe send an email to pywikibot-commits-le...@lists.wikimedia.org
