jenkins-bot has submitted this change. ( 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/791491 )

Change subject: random.sample() instead of random.shuffle()
......................................................................

random.sample() instead of random.shuffle()

Bug: T308266
Change-Id: Ic66e6c9c792b0f77d411b9f050200f9eb05aac78
---
M tests/site_tests.py
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Xqt: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/site_tests.py b/tests/site_tests.py
index 4698341..4b43f71 100755
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -3275,8 +3275,7 @@
         size = 20
         small_wikis = self.site.family.languages_by_size[-size:]
         great_wikis = self.site.family.languages_by_size[:-size]
-        random.shuffle(great_wikis)
-        great_wikis = great_wikis[:size]
+        great_wikis = random.sample(great_wikis, size)
         for code in sorted(small_wikis + great_wikis):
             site = pywikibot.Site(code, self.family)
             with self.subTest(site=site):

--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/791491
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.wikimedia.org/r/settings

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ic66e6c9c792b0f77d411b9f050200f9eb05aac78
Gerrit-Change-Number: 791491
Gerrit-PatchSet: 3
Gerrit-Owner: Klein Muçi <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to