jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/806456 )
Change subject: [bugfix] assign compareLanguages results to be used later
......................................................................
[bugfix] assign compareLanguages results to be used later
- do not hide comment and adding result from compareLanguages
- also fix process_limit_two call
- always print exception traceback if it is the last resort for
easoer debugging
Bug: T310908
Change-Id: I0c2454dc8e08c19db6607616d0cff74a4b79f8f2
---
M scripts/interwiki.py
1 file changed, 4 insertions(+), 8 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/interwiki.py b/scripts/interwiki.py
index bdfb08b..e217308 100755
--- a/scripts/interwiki.py
+++ b/scripts/interwiki.py
@@ -1467,7 +1467,7 @@
# Process all languages here
self.conf.always = False
if self.conf.limittwo:
- self.process_limittwo(new, updatedSites)
+ self.process_limit_two(new, updatedSites)
else:
self.process_unlimited(new, updatedSites)
@@ -1616,7 +1616,7 @@
old[page2.site] = page2
# Check what needs to get done
- mods, _comment, _adding, removing, modifying = compareLanguages(
+ mods, mcomment, adding, removing, modifying = compareLanguages(
old, new, page.site, self.conf.summary)
# When running in autonomous mode without -force switch, make sure we
@@ -1637,11 +1637,7 @@
'disambiguation state.'.format(rmPage))
# Re-Check what needs to get done
mods, mcomment, adding, removing, modifying = compareLanguages(
- old,
- new,
- page.site,
- self.conf.summary
- )
+ old, new, page.site, self.conf.summary)
if not mods:
self.conf.note('No changes needed on page {}'.format(page))
return False
@@ -2430,7 +2426,7 @@
except KeyboardInterrupt:
dump.write_dump(bot.dump_titles, append)
except Exception:
- pywikibot.exception(exc_info=bool(config.verbose_output))
+ pywikibot.exception()
dump.write_dump(bot.dump_titles, append)
else:
pywikibot.output('Script terminated sucessfully.')
--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/806456
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I0c2454dc8e08c19db6607616d0cff74a4b79f8f2
Gerrit-Change-Number: 806456
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: D3r1ck01 <[email protected]>
Gerrit-Reviewer: Prod <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
