jenkins-bot has submitted this change. ( 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/868094 )

Change subject: [IMPR] Remove obsolete code from BaseSite.__getattr__()
......................................................................

[IMPR] Remove obsolete code from BaseSite.__getattr__()

__getattr__ is only called when the default attribute access fails

Change-Id: Ieddaeb938fffb032cef20f4bf0f9890b9131c701
---
M pywikibot/site/_basesite.py
1 file changed, 11 insertions(+), 2 deletions(-)

Approvals:
  RoySmith: Looks good to me, but someone else must approve
  Xqt: Looks good to me, approved
  jenkins-bot: Verified




diff --git a/pywikibot/site/_basesite.py b/pywikibot/site/_basesite.py
index 80dacc7..de5f5c9 100644
--- a/pywikibot/site/_basesite.py
+++ b/pywikibot/site/_basesite.py
@@ -186,8 +186,6 @@

     def __getattr__(self, attr):
         """Delegate undefined methods calls to the Family object."""
-        if hasattr(self.__class__, attr):
-            return getattr(self.__class__, attr)
         try:
             method = getattr(self.family, attr)
             if not callable(method):

--
To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/868094
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.wikimedia.org/r/settings

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ieddaeb938fffb032cef20f4bf0f9890b9131c701
Gerrit-Change-Number: 868094
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <i...@gno.de>
Gerrit-Reviewer: RoySmith <r...@panix.com>
Gerrit-Reviewer: Russell Blau <russb...@imapmail.org>
Gerrit-Reviewer: Xqt <i...@gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged
_______________________________________________
Pywikibot-commits mailing list -- pywikibot-commits@lists.wikimedia.org
To unsubscribe send an email to pywikibot-commits-le...@lists.wikimedia.org

Reply via email to