jenkins-bot has submitted this change. ( 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1077062?usp=email )

Change subject: [tests] Use list instead of set in 
test_randomredirect_generator_default
......................................................................

[tests] Use list instead of set in test_randomredirect_generator_default

This prevents creating a hash for the page which needs the page title.
The title method may fail with InvalidTitleError within Link parse().

Bug: T376154
Change-Id: I00063e01ddc5476d75cf75791f35c4e4a6753621
---
M tests/pagegenerators_tests.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Xqt: Looks good to me, approved




diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 77ed29a..4e42053 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -1208,7 +1208,7 @@
         gf.handle_arg('-randomredirect:1')
         gen = gf.getCombinedGenerator()
         self.assertIsNotNone(gen)
-        pages = set(gen)
+        pages = list(gen)
         self.assertLength(pages, 1)

     def test_randomredirect_generator_ns(self):

--
To view, visit 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1077062?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.wikimedia.org/r/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I00063e01ddc5476d75cf75791f35c4e4a6753621
Gerrit-Change-Number: 1077062
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <i...@gno.de>
Gerrit-Reviewer: Xqt <i...@gno.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- pywikibot-commits@lists.wikimedia.org
To unsubscribe send an email to pywikibot-commits-le...@lists.wikimedia.org

Reply via email to