Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1086009?usp=email )
Change subject: [doc] Capitalize TODOs ...................................................................... [doc] Capitalize TODOs Change-Id: I242bc5a1a6ce9bcde2d19ea6076861ebe7a76f1c --- M pywikibot/page/_wikibase.py M scripts/coordinate_import.py M scripts/harvest_template.py M scripts/interwiki.py M scripts/interwikidata.py M scripts/parser_function_count.py 6 files changed, 12 insertions(+), 12 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/page/_wikibase.py b/pywikibot/page/_wikibase.py index bea70cd..047c690 100644 --- a/pywikibot/page/_wikibase.py +++ b/pywikibot/page/_wikibase.py @@ -726,7 +726,7 @@ '{}.get does not implement var args: {!r} and {!r}'.format( self.__class__.__name__, args, kwargs)) - # todo: this variable is specific to ItemPage + # TODO: this variable is specific to ItemPage lazy_loading_id = not hasattr(self, 'id') and hasattr(self, '_site') try: data = WikibaseEntity.get(self, force=force) @@ -735,7 +735,7 @@ p = pywikibot.Page(self._site, self._title) if not p.exists(): raise NoPageError(p) - # todo: raise a nicer exception here (T87345) + # TODO: raise a nicer exception here (T87345) raise NoPageError(self) if 'pageid' in self._content: @@ -1509,7 +1509,7 @@ def newClaim(self, *args, **kwargs) -> Claim: """Helper function to create a new claim object for this property.""" - # todo: raise when self.id is -1 + # TODO: raise when self.id is -1 return Claim(self.site, self.getID(), *args, datatype=self.type, **kwargs) @@ -2095,7 +2095,7 @@ :return: JSON value """ - # todo: eventually unify the following two groups + # TODO: eventually unify the following two groups if self.type in ('wikibase-item', 'wikibase-property'): value = {'entity-type': self.getTarget().entity_type, 'numeric-id': self.getTarget().getID(numeric=True)} @@ -2303,7 +2303,7 @@ form.on_lexeme = None form.id = '-1' - # todo: senses + # TODO: senses def mergeInto(self, lexeme, **kwargs): """Merge the lexeme into another lexeme. diff --git a/scripts/coordinate_import.py b/scripts/coordinate_import.py index e161127..3886ce6 100755 --- a/scripts/coordinate_import.py +++ b/scripts/coordinate_import.py @@ -139,7 +139,7 @@ pywikibot.info( f'Adding {coordinate.lat}, {coordinate.lon} to {item.title()}') - # todo: handle exceptions using self.user_add_claim + # TODO: handle exceptions using self.user_add_claim try: item.addClaim(newclaim) except CoordinateGlobeUnknownError as e: diff --git a/scripts/harvest_template.py b/scripts/harvest_template.py index 30ca6c4..91d2248 100755 --- a/scripts/harvest_template.py +++ b/scripts/harvest_template.py @@ -329,9 +329,9 @@ if not field or field not in self.fields: return - # todo: extend the list of tags to ignore + # TODO: extend the list of tags to ignore value = textlib.removeDisabledParts( - # todo: eventually we may want to import the references + # TODO: eventually we may want to import the references value, tags=['ref'], site=site).strip() if not value: diff --git a/scripts/interwiki.py b/scripts/interwiki.py index 7cff604..8389d97 100755 --- a/scripts/interwiki.py +++ b/scripts/interwiki.py @@ -650,7 +650,7 @@ super().__init__(origin) - # todo is a list of all pages that still need to be analyzed. + # TODO is a list of all pages that still need to be analyzed. # Mark the origin page as todo. self.todo = SizedKeyCollection('site') if origin: @@ -1274,7 +1274,7 @@ counter.minus(page.site) # Now check whether any interwiki links should be added to the - # todo list. + # TODO list. self.check_page(page, counter) # These pages are no longer 'in progress' diff --git a/scripts/interwikidata.py b/scripts/interwikidata.py index 328c011..5187f42 100755 --- a/scripts/interwikidata.py +++ b/scripts/interwikidata.py @@ -212,7 +212,7 @@ """Merge two items.""" wd_data = self.get_items() if not wd_data: - # todo: add links to item + # TODO: add links to item return None if len(wd_data) > 1: diff --git a/scripts/parser_function_count.py b/scripts/parser_function_count.py index da298bb..5900508 100755 --- a/scripts/parser_function_count.py +++ b/scripts/parser_function_count.py @@ -58,7 +58,7 @@ from pywikibot.bot import ExistingPageBot, SingleSiteBot -# Todo: +# TODO: # * Using xml and xmlstart # * Using categories # * Error handling for uploading (anyway, that's the last action, it's only -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1086009?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I242bc5a1a6ce9bcde2d19ea6076861ebe7a76f1c Gerrit-Change-Number: 1086009 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <i...@gno.de> Gerrit-Reviewer: D3r1ck01 <dalangi-...@wikimedia.org> Gerrit-Reviewer: Xqt <i...@gno.de> Gerrit-Reviewer: jenkins-bot
_______________________________________________ Pywikibot-commits mailing list -- pywikibot-commits@lists.wikimedia.org To unsubscribe send an email to pywikibot-commits-le...@lists.wikimedia.org