jenkins-bot has submitted this change. ( 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1179285?usp=email )

Change subject: don't require 18n module when a manual summary is provided
......................................................................

don't require 18n module when a manual summary is provided

if a manual summary is provided then loading the automatic
translations is unnecessary and forces the user to have installed
the i18n submodule.

Change-Id: Ifa5f15e570094edd877c820cb50087beffd9bf55
---
M scripts/replace.py
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Xqt: Looks good to me, approved




diff --git a/scripts/replace.py b/scripts/replace.py
index 7414bfc..176da68 100755
--- a/scripts/replace.py
+++ b/scripts/replace.py
@@ -1006,7 +1006,9 @@

     # The summary stored here won't be actually used but is only an example
     site = pywikibot.Site()
-    single_summary = None
+    single_summary = (
+        'Not needed' if edit_summary and edit_summary is not True else None
+    )
     for old, new in batched(commandline_replacements, 2):
         replacement = Replacement(old, new)
         if not single_summary:

--
To view, visit 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1179285?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.wikimedia.org/r/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ifa5f15e570094edd877c820cb50087beffd9bf55
Gerrit-Change-Number: 1179285
Gerrit-PatchSet: 4
Gerrit-Owner: Lokal Profil <lokal.pro...@gmail.com>
Gerrit-Reviewer: Xqt <i...@gno.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- pywikibot-commits@lists.wikimedia.org
To unsubscribe send an email to pywikibot-commits-le...@lists.wikimedia.org

Reply via email to