jenkins-bot has submitted this change. ( 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1199728?usp=email )

Change subject: Tests: temporary exclude testwiki from some rc tests
......................................................................

Tests: temporary exclude testwiki from some rc tests

Also use subTests in TestRecentChanges.test_flags

Bug: T408667
Change-Id: I4ebd07649629aa85f2dc20acbca790e588f4d379
---
M tests/site_generators_tests.py
1 file changed, 34 insertions(+), 22 deletions(-)

Approvals:
  Xqt: Looks good to me, approved
  jenkins-bot: Verified




diff --git a/tests/site_generators_tests.py b/tests/site_generators_tests.py
index 950ee1e..01d69bb 100755
--- a/tests/site_generators_tests.py
+++ b/tests/site_generators_tests.py
@@ -965,28 +965,40 @@
     def test_flags(self) -> None:
         """Test the site.recentchanges() with boolean flags."""
         mysite = self.site
-        for change in mysite.recentchanges(minor=True, total=5):
-            self.assertIsInstance(change, dict)
-            self.assertIn('minor', change)
-        for change in mysite.recentchanges(minor=False, total=5):
-            self.assertIsInstance(change, dict)
-            self.assertNotIn('minor', change)
-        for change in mysite.recentchanges(bot=True, total=5):
-            self.assertIsInstance(change, dict)
-            self.assertIn('bot', change)
-        for change in mysite.recentchanges(bot=False, total=5):
-            self.assertIsInstance(change, dict)
-            self.assertNotIn('bot', change)
-        for change in mysite.recentchanges(anon=True, total=5):
-            self.assertIsInstance(change, dict)
-        for change in mysite.recentchanges(anon=False, total=5):
-            self.assertIsInstance(change, dict)
-        for change in mysite.recentchanges(redirect=False, total=5):
-            self.assertIsInstance(change, dict)
-            self.assertNotIn('redirect', change)
-        for change in mysite.recentchanges(redirect=True, total=5):
-            self.assertIsInstance(change, dict)
-            self.assertIn('redirect', change)
+        with self.subTest(minor=True):
+            for change in mysite.recentchanges(minor=True, total=5):
+                self.assertIsInstance(change, dict)
+                self.assertIn('minor', change)
+        with self.subTest(minor=False):
+            for change in mysite.recentchanges(minor=False, total=5):
+                self.assertIsInstance(change, dict)
+                self.assertNotIn('minor', change)
+        with self.subTest(bot=True):
+            for change in mysite.recentchanges(bot=True, total=5):
+                self.assertIsInstance(change, dict)
+                self.assertIn('bot', change)
+        with self.subTest(bot=False):
+            for change in mysite.recentchanges(bot=False, total=5):
+                self.assertIsInstance(change, dict)
+                self.assertNotIn('bot', change)
+        with self.subTest(anon=True):
+            for change in mysite.recentchanges(anon=True, total=5):
+                self.assertIsInstance(change, dict)
+        with self.subTest(anon=False):
+            for change in mysite.recentchanges(anon=False, total=5):
+                self.assertIsInstance(change, dict)
+        with self.subTest(redirect=True):
+            if mysite.sitename == 'wikipedia:test':
+                self.skipTest('Faulty rcshow filter: T408667')
+            for change in mysite.recentchanges(redirect=True, total=5):
+                self.assertIsInstance(change, dict)
+                self.assertIn('redirect', change)
+        with self.subTest(redirect=False):
+            if mysite.sitename == 'wikipedia:test':
+                self.skipTest('Faulty rcshow filter: T408667')
+            for change in mysite.recentchanges(redirect=False, total=5):
+                self.assertIsInstance(change, dict)
+                self.assertNotIn('redirect', change)

     def test_tag_filter(self) -> None:
         """Test the site.recentchanges() with tag filter."""

--
To view, visit 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1199728?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.wikimedia.org/r/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I4ebd07649629aa85f2dc20acbca790e588f4d379
Gerrit-Change-Number: 1199728
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to