jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203212?usp=email )
Change subject: mypy: fix mypy issues in page/_user.py
......................................................................
mypy: fix mypy issues in page/_user.py
Change-Id: I6ba6e9974026e5b4c092e482887a3a53575013aa
---
M .pre-commit-config.yaml
M conftest.py
M pywikibot/page/_user.py
3 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index c54829d..0447dc4 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -131,7 +131,7 @@
comms/eventstreams|
data/(api/(__init__|_optionset)|citoid|memento|wikistats)|
families/[a-z][a-z\d]+_family|
- page/(__init__|_decorators|_page|_revision)|
+ page/(__init__|_decorators|_page|_revision|_user)|
pagegenerators/(__init__|_filters)|
scripts/(?:i18n/)?__init__|
site/(__init__|_basesite|_decorators|_interwikimap|_tokenwallet|_upload)|
diff --git a/conftest.py b/conftest.py
index 2f93dee..b4a7b8d 100644
--- a/conftest.py
+++ b/conftest.py
@@ -22,7 +22,7 @@
r'comms/eventstreams|'
r'data/(api/(__init__|_optionset)|citoid|memento|wikistats)|'
r'families/[a-z][a-z\d]+_family|'
- r'page/(__init__|_decorators|_page|_revision)|'
+ r'page/(__init__|_decorators|_page|_revision|_user)|'
r'pagegenerators/(__init__|_filters)|'
r'scripts/(i18n/)?__init__|'
r'site/(__init__|_basesite|_decorators|_interwikimap|'
diff --git a/pywikibot/page/_user.py b/pywikibot/page/_user.py
index 820eda32..9d4ea52 100644
--- a/pywikibot/page/_user.py
+++ b/pywikibot/page/_user.py
@@ -7,6 +7,7 @@
from __future__ import annotations
from collections.abc import Generator
+from typing import Any
import pywikibot
from pywikibot.exceptions import (
@@ -102,7 +103,7 @@
"""
return is_ip_network(self.username)
- def getprops(self, force: bool = False) -> dict:
+ def getprops(self, force: bool = False) -> dict[str, Any]:
"""Return a properties about the user.
.. versionchanged:: 9.0
@@ -111,7 +112,9 @@
:param force: if True, forces reloading the data from API
"""
if force and hasattr(self, '_userprops'):
+ self._userprops: dict[str, Any]
del self._userprops
+
if not hasattr(self, '_userprops'):
self._userprops = next(self.site.users([self.username]))
if self.isAnonymous() or self.is_CIDR():
@@ -120,6 +123,7 @@
if r:
self._userprops['blockedby'] = r['by']
self._userprops['blockreason'] = r['reason']
+
return self._userprops
def registration(self,
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1203212?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I6ba6e9974026e5b4c092e482887a3a53575013aa
Gerrit-Change-Number: 1203212
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
