jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1224578?usp=email )
Change subject: tests: Simplify TestSiteObject.test_constructors test_list
......................................................................
tests: Simplify TestSiteObject.test_constructors test_list
Change-Id: I49254d3d9bcc47e2fd70aecda77d9751106a13dd
---
M tests/site_tests.py
1 file changed, 17 insertions(+), 17 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/site_tests.py b/tests/site_tests.py
index f4dd61f..cc3ddfa 100755
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -1,7 +1,7 @@
#!/usr/bin/env python3
"""Tests for the site module."""
#
-# (C) Pywikibot team, 2008-2025
+# (C) Pywikibot team, 2008-2026
#
# Distributed under the terms of the MIT license.
#
@@ -60,26 +60,26 @@
def test_constructors(self) -> None:
"""Test cases for site constructors."""
- test_list = [
- ['alswiki', 'wikipedia:als'], # see T345036
- ['commonswiki', 'commons:commons'],
- ['dewikinews', 'wikinews:de'],
- ['enwiki', 'wikipedia:en'],
- ['eswikisource', 'wikisource:es'],
- ['metawiki', 'meta:meta'],
- ['roa_rupwiki', 'wikipedia:roa-rup'], # see T345036
- ['sourceswiki', 'wikisource:mul'], # see T226960
- ['test2wiki', 'wikipedia:test2'], # see T225729
- ['testwiki', 'wikipedia:test'], # see T225729, T228300
- ['testwikidatawiki', 'wikidata:test'],
- ['ukwikivoyage', 'wikivoyage:uk'],
- ['wikidatawiki', 'wikidata:wikidata'],
- ]
+ test_dict = {
+ 'alswiki': 'wikipedia:als', # see T345036
+ 'commonswiki': 'commons:commons',
+ 'dewikinews': 'wikinews:de',
+ 'enwiki': 'wikipedia:en',
+ 'eswikisource': 'wikisource:es',
+ 'metawiki': 'meta:meta',
+ 'roa_rupwiki': 'wikipedia:roa-rup', # see T345036
+ 'sourceswiki': 'wikisource:mul', # see T226960
+ 'test2wiki': 'wikipedia:test2', # see T225729
+ 'testwiki': 'wikipedia:test', # see T225729, T228300
+ 'testwikidatawiki': 'wikidata:test',
+ 'ukwikivoyage': 'wikivoyage:uk',
+ 'wikidatawiki': 'wikidata:wikidata',
+ }
if isinstance(self.site.family, pywikibot.family.WikimediaFamily):
site = self.site
else:
site = None
- for dbname, sitename in test_list:
+ for dbname, sitename in test_dict.items():
with self.subTest(dbname=dbname):
self.assertIs(
pywikibot.site.APISite.fromDBName(dbname, site),
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1224578?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I49254d3d9bcc47e2fd70aecda77d9751106a13dd
Gerrit-Change-Number: 1224578
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
