Xqt has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1305916?usp=email )
Change subject: [bugfix] Remove obsolete WMF_CACERT legacy check
......................................................................
[bugfix] Remove obsolete WMF_CACERT legacy check
Since Wikimedia's current certificate chain is valid and trusted by
modern certifi (via ISRG Root X2), the original WMF_CACERT check
is no longer meaningful.
Bug: T430266
Change-Id: Iced8596755f87815bca36a39c69e511ab76587ef
---
M pywikibot/scripts/version.py
1 file changed, 0 insertions(+), 12 deletions(-)
Approvals:
Xqt: Verified; Looks good to me, approved
diff --git a/pywikibot/scripts/version.py b/pywikibot/scripts/version.py
index 758af4d..f65f532 100755
--- a/pywikibot/scripts/version.py
+++ b/pywikibot/scripts/version.py
@@ -70,9 +70,6 @@
requests = DummyModule()
-WMF_CACERT = 'MIIDxTCCAq2gAwIBAgIQAqxcJmoLQJuPC3nyrkYldzANBgkqhkiG9w0BAQUFADBs'
-
-
def main(*args: str) -> None:
"""Print pywikibot version and important settings.
@@ -86,7 +83,6 @@
pywikibot.info('wikitextparser version: ' + wikitextparser.__version__)
pywikibot.info('requests version: ' + requests.__version__)
- has_wikimedia_cert = False
if (not hasattr(requests, 'certs')
or not hasattr(requests.certs, 'where')
or not callable(requests.certs.where)):
@@ -99,14 +95,6 @@
pywikibot.info(f' cacerts: {cert.name} (missing)')
else:
pywikibot.info(f' cacerts: {cert}')
- text = cert.read_text(encoding='utf-8')
- if WMF_CACERT in text:
- has_wikimedia_cert = True
- pywikibot.info(' certificate test: {}'
- .format('ok' if has_wikimedia_cert else 'not ok'))
-
- if not has_wikimedia_cert:
- pywikibot.info(' Please reinstall requests!')
pywikibot.info('Python: ' + sys.version)
pywikibot.info('User-Agent: ' + user_agent(pywikibot.Site()))
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1305916?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Iced8596755f87815bca36a39c69e511ab76587ef
Gerrit-Change-Number: 1305916
Gerrit-PatchSet: 1
Gerrit-Owner: Zaidusyy <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
