Xqt has submitted this change. ( 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1307549?usp=email )

Change subject: [bugfix] description variable cannot be None in upload.py script
......................................................................

[bugfix] description variable cannot be None in upload.py script

description variable contains a string from joined description list,
or from description file. It cannot be None. Test for not description
instead.

Change-Id: I55d5ca98ca5248b8029c9e06947389073c541497
---
M scripts/upload.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Xqt: Looks good to me, approved
  jenkins-bot: Verified




diff --git a/scripts/upload.py b/scripts/upload.py
index a10f06e..7524843 100755
--- a/scripts/upload.py
+++ b/scripts/upload.py
@@ -213,7 +213,7 @@
         if url is None:
             missing.append('filename')
             additional = error + ' '
-        if description is None:
+        if not description:
             missing.append('description')
         if aborts is not True and ignorewarn is not True:
             additional += ('Either -ignorewarn or -abortonwarn must be '

--
To view, visit 
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1307549?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.wikimedia.org/r/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I55d5ca98ca5248b8029c9e06947389073c541497
Gerrit-Change-Number: 1307549
Gerrit-PatchSet: 3
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to